Skip to content

Fix broken deploy and dependabot CI checks - #131

Merged
wrynearson merged 1 commit into
mainfrom
fix/deploy-pnpm-version-and-ruff-lint
Sep 10, 2026
Merged

wrynearson merged 1 commit into
mainfrom
fix/deploy-pnpm-version-and-ruff-lint

Conversation

@wrynearson

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • uv run ruff check passes
  • uv run ruff format --check passes
  • uv run python validate_satellites.py passes
  • pnpm format:check passes

🤖 Generated with Claude Code

- Bump pnpm/action-setup in deploy.yml from 9 to 10, matching ci.yml.
  Version 9 doesn't understand a pnpm-workspace.yaml without a
  `packages:` key (added in #130), so every scheduled deploy since
  has failed at `pnpm install`.
- Ignore pnpm-lock.yaml in Prettier. Dependabot regenerates it without
  running Prettier, so `pnpm format:check` has been failing on every
  npm dependabot PR since May.
- Fix the ruff 0.16.1 lint errors introduced on main by #126
  (unused unpacked variables, datetime.UTC alias, explicit
  subprocess.run check=, and a missing executable bit matching the
  shebang in validate_satellites.py).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 10, 2026

Copy link
Copy Markdown

Claude finished @wrynearson's task in 53s —— View job


Reviewing PR #131

  • Gather context (diff, changed files)
  • Review correctness/security/best-practice issues
  • Ponytail pass for over-engineering
  • Post final review

✅ No blocking issues — safe to merge.

  • deploy.yml pnpm version bump to 10 now matches ci.yml, which fixes the pnpm-workspace.yaml packages: field error.
  • .prettierignore addition correctly excludes the dependabot-regenerated lockfile from prettier --check.
  • generate_satellite_paths.py / validate_satellites.py changes are mechanical ruff 0.16.1 fixes (unused-var prefixing, datetime.UTC, PEP 604 X | None typing, executable bit) and are behavior-preserving.

One non-blocking observation:

  • scripts/generate_satellite_paths.py:507 — the new check=False on the tippecanoe subprocess.run call preserves prior (implicit) behavior, but it means a failing/missing tippecanoe binary is silently swallowed — the script still prints "Successfully generated tiles..." and "Tiles generated successfully..." afterward (lines 508, 510) even if tile generation failed. Since this PR already had to touch this line to satisfy ruff's subprocess-run-without-check rule, it may be worth using check=True instead so pipeline failures actually fail the script/CI run:
    subprocess.run(
        [...],
        check=True,
    )
    Not a regression introduced by this PR (default was already non-raising), so not blocking.

Simplify (ponytail)

Nothing to flag — this diff is a version bump, an ignore-file entry, and mechanical linter fixes; no new abstractions or dependencies introduced.


💰 Estimated review cost: $0.25 · 0m52s · 13 turns

@wrynearson
wrynearson merged commit 9bea9ad into main Sep 10, 2026
3 checks passed
@wrynearson
wrynearson deleted the fix/deploy-pnpm-version-and-ruff-lint branch September 10, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant