Fix broken deploy and dependabot CI checks - #131
Merged
Merged
Conversation
- Bump pnpm/action-setup in deploy.yml from 9 to 10, matching ci.yml. Version 9 doesn't understand a pnpm-workspace.yaml without a `packages:` key (added in #130), so every scheduled deploy since has failed at `pnpm install`. - Ignore pnpm-lock.yaml in Prettier. Dependabot regenerates it without running Prettier, so `pnpm format:check` has been failing on every npm dependabot PR since May. - Fix the ruff 0.16.1 lint errors introduced on main by #126 (unused unpacked variables, datetime.UTC alias, explicit subprocess.run check=, and a missing executable bit matching the shebang in validate_satellites.py). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Claude finished @wrynearson's task in 53s —— View job Reviewing PR #131
✅ No blocking issues — safe to merge.
One non-blocking observation:
Simplify (ponytail) Nothing to flag — this diff is a version bump, an ignore-file entry, and mechanical linter fixes; no new abstractions or dependencies introduced. 💰 Estimated review cost: $0.25 · 0m52s · 13 turns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm/action-setupindeploy.ymlfrom 9 to 10, matchingci.yml. Version 9 doesn't understand apnpm-workspace.yamlwithout apackages:key (added in Add AOI upload with map-view-aware pass counting #130), so every scheduled deploy since has failed atpnpm installwithpackages field missing or empty.pnpm-lock.yamlto.prettierignore. Dependabot regenerates the lockfile without running Prettier, sopnpm format:checkhas been failing on every npm dependabot PR since May (Bump @radix-ui/react-slot from 1.2.3 to 1.3.3 #119, Bump pmtiles from 4.3.0 to 4.4.1 #118, Bump typescript from 5.9.2 to 5.9.3 #117, Bump @vitejs/plugin-react from 5.0.3 to 5.2.0 #116, Bump eslint-plugin-react-refresh from 0.4.20 to 0.5.3 #115).mainby Bump ruff from 0.15.10 to 0.16.1 in /scripts #126 (unused unpacked variables,datetime.UTCalias, explicitsubprocess.run(check=...), and a missing executable bit matching the shebang invalidate_satellites.py).Test plan
uv run ruff checkpassesuv run ruff format --checkpassesuv run python validate_satellites.pypassespnpm format:checkpasses🤖 Generated with Claude Code