Skip to content

remote.h: fix space-only indentation in get_remote_group() declaration - #14

Merged
Faisal M. AlOtaibi (hub966) merged 2 commits into
masterfrom
copilot/fix-check-whitespace-job-another-one
Sep 18, 2026
Merged

Faisal M. AlOtaibi (hub966) merged 2 commits into
masterfrom
copilot/fix-check-whitespace-job-another-one

Conversation

Copilot AI commented Jul 31, 2026 •

Copy link
Copy Markdown

Commit 3e7b9dce27 ("remote: move remote group resolution to remote.c") introduced the get_remote_group() declaration in remote.h using pure-space indentation on its continuation lines, triggering the indent-with-non-tab whitespace check enforced by .gitattributes (*.[ch] whitespace=indent,trail,space,incomplete) and failing the check-whitespace CI job.

Change

  • remote.h: Replace all-space indentation on the get_remote_group() parameter continuation lines with proper tab-based alignment (2 tabs + 5 spaces = 21 chars, aligning to the opening (), consistent with the established style across remote.h:
// Before (triggers "indent with spaces" error)
int get_remote_group(const char *key, const char *value,
                     const struct config_context *ctx,
                     void *priv);

// After
int get_remote_group(const char *key, const char *value,
		     const struct config_context *ctx,
		     void *priv);

Running ci/check-whitespace.sh against the corrected tree exits 0.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job check-whitespace remote.h: fix space-only indentation in get_remote_group() declaration Jul 31, 2026
Copilot AI review requested due to automatic review settings July 31, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@hub966
Faisal M. AlOtaibi (hub966) changed the base branch from master to maint August 1, 2026 08:54
@hub966
Faisal M. AlOtaibi (hub966) marked this pull request as ready for review September 17, 2026 22:51
This was linked to issues Sep 18, 2026
@hub966
Faisal M. AlOtaibi (hub966) changed the base branch from maint to master September 18, 2026 16:20
@hub966
Faisal M. AlOtaibi (hub966) merged commit 5802a68 into master Sep 18, 2026
35 of 37 checks passed
@github-project-automation github-project-automation Bot moved this from Agenda ✍ to What can be improved 🟡 in @hub966's untitled project Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUROCRACIA DIGITAL BUROCRACIA DIGITAL

3 participants