Skip to content

Add Text and LineCount to UpdateUI - #196

Merged
desjarlais merged 2 commits into
desjarlais:masterfrom
toehead2001:text-and-lineCount
Oct 12, 2026
Merged

desjarlais merged 2 commits into
desjarlais:masterfrom
toehead2001:text-and-lineCount

Conversation

@toehead2001

Copy link
Copy Markdown
Contributor

Requires Scintilla to upgraded to v5.6.5+ first.

This adds support for the SC_UPDATE_TEXT and SC_UPDATE_LINE_COUNT flags on SCN_UPDATEUI
https://www.scintilla.org/ScintillaDoc.html#SCN_UPDATEUI

scn.position will only return a position, if the update contains the SC_UPDATE_TEXT flag. Otherwise, it will return -1 (aka InvalidPosition).

@ahmetsait

Copy link
Copy Markdown
Collaborator

You should rebase onto ahmetsait:update-native.

@toehead2001
toehead2001 marked this pull request as ready for review October 11, 2026 00:21
Comment thread Scintilla.NET/UpdateChange.cs Outdated
Comment on lines +45 to +46
LineCount = SciApi.SC_UPDATE_LINE_COUNT

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the empty line and add a trailing comma.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@desjarlais
desjarlais merged commit e39c845 into desjarlais:master Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants