Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/deployml/docker/grafana-container/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ FROM grafana/grafana:10.4.5
USER root

# Configure Grafana to listen on Cloud Run's expected port
ENV GF_SERVER_HTTP_PORT=8080 \
GF_SECURITY_ADMIN_USER=admin \
GF_SECURITY_ADMIN_PASSWORD=admin
ENV GF_SERVER_HTTP_PORT=8080

# Copy entrypoint script and set permissions
COPY entrypoint.sh /usr/local/bin/entrypoint.sh
Expand Down
2 changes: 2 additions & 0 deletions src/deployml/templates/gcp/cloud_run/main.tf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ module "{{ stage_name }}_{{ tool.name }}" {
cpu_limit = var.cpu_limit
memory_limit = var.memory_limit
allow_public_access = var.allow_public_access
grafana_admin_user = "{{ tool.params.get('grafana_admin_user', 'admin') }}"
grafana_admin_password = "{{ tool.params.get('grafana_admin_password', 'admin') }}"
{% if flags.needs_postgres %}
metrics_connection_string = module.cloud_sql_postgres.grafana_connection_string_cloud_sql
use_metrics_database = true
Expand Down
2 changes: 2 additions & 0 deletions src/deployml/templates/gcp/cloud_run/mlflow_main.tf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,8 @@ module "{{ stage_name }}_{{ tool.name }}" {
cpu_limit = var.cpu_limit
memory_limit = var.memory_limit
allow_public_access = var.allow_public_access
grafana_admin_user = "{{ tool.params.get('grafana_admin_user', 'admin') }}"
grafana_admin_password = "{{ tool.params.get('grafana_admin_password', 'admin') }}"
{% if flags.needs_postgres %}
metrics_connection_string = module.cloud_sql_postgres.grafana_connection_string_cloud_sql
use_metrics_database = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@ resource "google_cloud_run_service" "grafana" {
name = "GF_SERVER_HTTP_PORT"
value = "8080"
}
env {
name = "GF_SECURITY_ADMIN_USER"
value = var.grafana_admin_user
}
env {
name = "GF_SECURITY_ADMIN_PASSWORD"
value = var.grafana_admin_password
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,17 @@ variable "cloudsql_instance_annotation" {
type = string
description = "Cloud SQL instance connection annotation"
default = ""
}

variable "grafana_admin_user" {
type = string
description = "Admin username for Grafana"
default = "admin"
}

variable "grafana_admin_password" {
type = string
description = "Admin password for Grafana"
default = "admin"
sensitive = true
}