Use community fork of runner-container-hooks with websocket heartbeat fix#1
Merged
Merged
Conversation
… fix Pulls k8s and k8s-novolume runner-container-hooks from oradwell/runner-container-hooks (v0.7.1-alpha / v0.8.2-alpha) instead of upstream. These community alpha releases backport PR actions/runner-container-hooks#333, which adds a websocket heartbeat to the kubernetes exec call. Without it, workflow steps that produce no output for ~5 minutes (e.g. long sleeps, silent test runs) cause the websocket to close and the step to be reported as exit 0, masking real failures. See actions/runner-container-hooks#228. Upstream has not yet cut a release containing the fix. Revert to the upstream repo once a tagged release ships. Also adds an optional tagSuffix workflow_dispatch input to docker-publish.yml so custom builds can be published as e.g. 2.333.1-hooksfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls k8s and k8s-novolume runner-container-hooks from oradwell/runner-container-hooks (v0.7.1-alpha / v0.8.2-alpha) instead of upstream. These community alpha releases backport PR actions/runner-container-hooks#333, which adds a websocket heartbeat to the kubernetes exec call. Without it, workflow steps that produce no output for ~5 minutes (e.g. long sleeps, silent test runs) cause the websocket to close and the step to be reported as exit 0, masking real failures. See actions/runner-container-hooks#228.
Upstream has not yet cut a release containing the fix. Revert to the upstream repo once a tagged release ships.
Also adds an optional tagSuffix workflow_dispatch input to docker-publish.yml so custom builds can be published as e.g. 2.333.1-hooksfix.