Skip to content

fix(qe): honor angstrom cells without cel files#1029

Open
njzjz-bot wants to merge 2 commits into
deepmodeling:masterfrom
njzjz-bot:fix/issue-296
Open

fix(qe): honor angstrom cells without cel files#1029
njzjz-bot wants to merge 2 commits into
deepmodeling:masterfrom
njzjz-bot:fix/issue-296

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Fixes #296.

Respect an explicit CELL_PARAMETERS { angstrom } unit in QE cp/traj files when no .cel sidecar is present.

Tests: cd tests && python -m unittest test_qe_cp_traj test_qe_cp_traj_skipload

Why existing tests missed it: Existing tests covered Bohr/default input and sidecar cells, but not an Angstrom card without .cel.

Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. dpdata qe labels Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@njzjz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ff3b757e-6cc9-4fd6-b30e-8e1880c8d31f

📥 Commits

Reviewing files that changed from the base of the PR and between 0416b54 and efd318c.

📒 Files selected for processing (7)
  • dpdata/formats/qe/traj.py
  • tests/qe.traj/angstrom_no_cel/cp.in
  • tests/qe.traj/angstrom_no_cel/cp.pos
  • tests/qe.traj/bohr_no_cel/cp.in
  • tests/qe.traj/bohr_no_cel/cp.pos
  • tests/qe.traj/missing_cell_no_cel/cp.in
  • tests/test_qe_cp_traj.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jul 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 2 untouched benchmarks


Comparing njzjz-bot:fix/issue-296 (efd318c) with master (d2105f6)

Open in CodSpeed

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.01%. Comparing base (0416b54) to head (efd318c).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   86.87%   87.01%   +0.14%     
==========================================
  Files          89       90       +1     
  Lines        8266     9182     +916     
==========================================
+ Hits         7181     7990     +809     
- Misses       1085     1192     +107     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wanghan-iapcm wanghan-iapcm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #296 angstrom fix is correct and the new test genuinely fails on pre-fix code (10.44 vs 19.73). Requesting test coverage for the rewrite's other new branches, which codecov/patch flags red -- see inline.

Comment thread dpdata/formats/qe/traj.py
Exercise Bohr CELL_PARAMETERS without a cell trajectory and the missing-card error for ibrav zero.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dpdata qe size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Read qe/cp/traj with unit angstrom without .cel file

3 participants