fix(web): preserve computed definitions during rule metadata edits - #829
Merged
WaylandYang merged 2 commits intoSep 20, 2026
Merged
Conversation
Signed-off-by: dada-yan <BinjunYann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computed rules currently appear without their expression, and editing them through the ordinary form sends a definition without
conclude_expr, which the API rejects. Render their expression with attribute labels and preserve their definition by editing only name and description. Unknown expressions and values that the ordinary form cannot round-trip use the same protected metadata editor; failed saves retain the draft for retry.This addresses the existing-rule editing portion of #488. It does not introduce a computed-rule creation editor or decide unit/datatype semantics. Expression operands are displayed defensively, without claiming the current API accepts them on creation.
Validation:
Refs #488