Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for the Q2 port, @Aram164. Before merging I made a two minor changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #198
Port PDS Q2 from polars-benchmark to a skrub DAG and check Stratum against the original pandas query on the same Arrow-backed fixtures, following the existing Q1 pipeline test in tests/application/pds/test_q1_pipeline.py.
What it checks
The fixtures include tied minimum-cost suppliers and a cheaper supplier outside the selected region, plus wrong-size, wrong-type, and Asia-only parts so each filter is isolated. The prefix comparison normalizes row order, the full-query comparisons check the final sorted order.