[sig-migrate] Added multithreading support#369
Merged
Conversation
Signed-off-by: suselz <suselz@mail.ru>
AlwxSin
previously approved these changes
May 29, 2026
ldmonster
previously approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the d8 tools sig-migrate tool to support concurrent (multi-threaded) Kubernetes resource discovery and annotation, and introduces thread-safe writing of run artifacts (failed/error/skipped/trace logs) alongside new CLI knobs for tuning concurrency and measuring stage timings.
Changes:
- Add a worker-pool based implementation for resource collection and annotation (
--threads) plus retry logic for API calls. - Make file artifact writing thread-safe by reusing per-run writers with mutex protection.
- Add optional stage timing output (
--measure-stages) and update artifact file extensions/docs to.log.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
internal/tools/sigmigrate/sigmigrate.go |
Implements worker pools, retry wrappers, thread-safe artifact writers, and new timing/progress logic. |
internal/tools/sigmigrate/sigmigrate_test.go |
Updates tests for .log artifacts and adds coverage for worker normalization/retry/concurrent writes. |
internal/tools/sigmigrate/README.md |
Updates documented artifact filenames/extensions to .log. |
internal/tools/sigmigrate/cmd/flags.go |
Adds --threads and --measure-stages flags and centralizes the default --as value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: suselz <suselz@mail.ru>
Signed-off-by: suselz <suselz@mail.ru>
Signed-off-by: suselz <suselz@mail.ru>
…se-cli into sigmigrate-multithread
Signed-off-by: suselz <suselz@mail.ru>
ldmonster
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: