Repository navigation
ci: don't fail preview builds on broken internal links - #767
Merged
Merged
Conversation
## Short Summary (TL;DR) Preview builds now warn about broken internal links instead of failing, so a link to a post that isn't merged yet doesn't block the preview. The build in test.yml still fails on them. ## How This PR Solves The Issue `failOnBrokenLinks` is off when `PREVIEW_BUILD` is set, which the fork preview workflow now does, and on Cloudflare Pages builds of any branch other than `main`. This matches how textlint and prettier are already left out of previews. ## Manual Testing Instructions Run `PREVIEW_BUILD=true npm run build` with a broken internal link in a post, and check that it prints "Build continued with N broken links" and exits 0. Without the variable, the build fails. 🤖 Developed with assistance from [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
PR closed. The Cloudflare Pages preview is no longer updated. |
|
🌐 Fork Preview for PR #767 https://pr-767.ddev-com-fork-previews.pages.dev This preview updates automatically when you push changes to your fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
Preview builds now warn about broken internal links instead of failing, so a link to a post that isn't merged yet doesn't block the preview. The build in test.yml still fails on them.
How This PR Solves The Issue
failOnBrokenLinksis off whenPREVIEW_BUILDis set, which the fork preview workflow now does, and on Cloudflare Pages builds of any branch other thanmain. This matches how textlint and prettier are already left out of previews.Manual Testing Instructions
Run
PREVIEW_BUILD=true npm run buildwith a broken internal link in a post, and check that it prints "Build continued with N broken links" and exits 0. Without the variable, the build fails.🤖 Developed with assistance from Claude Code