Repository navigation
Build the tool from the checkout when no install provides it - #33
Merged
Merged
Conversation
When every documented install is skipped or yields no binary, kibble now builds the tool from the checkout with its language's standard build and runs the examples against it. A failed build reads BLOCKED. Crashes that come from the session's own environment read BLOCKED instead of FAIL.
Each collapsed details element is now a section of its own, so a setup that runs in a directory a sibling setup entered reads inherited-state. A URL host that did not resolve, named by an earlier line that did not pass, reads depends-on-skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no documented install gave the example session a binary, kibble skipped every example in the repository. Fifteen of the 97 pinned clones lost all their examples this way. This change builds the tool from the checkout instead, so one missing install route no longer costs every example, and it adds the rules that keep the newly reached lines honest.
Checkout build
When every install route is skipped, refused, or yields no binary, kibble builds the tool with its language's standard build and puts it on PATH. It builds only a tool it can name. Go uses
go installof the root or of thecmd/directory named for the repository or the only one there. Rust usescargo install --path .of the one binary or the one named for the repository, with--lockedwhen a lock file exists. Python usespip install .for the one console script or the one named for it, into a virtual environment of its own with the script linked onto PATH. A checkout that offers no such name builds nothing.Every example result says it was built from the checkout and the documented install was not tested. The install rows keep their own verdicts. A checkout that does not build reads BLOCKED with its error line or a timeout, since the failure belongs to kibble's stand-in and not to the document.
What the session receives
The session tree leaves out directories by name, such as
distandbuild, and the name is only a guess. A directory that holds files git tracks is now streamed whatever it is called, which goreleaser and k6 need to compile. A session that builds from the checkout also takes every tracked file whatever its size, so a vendored table over the usual 2 MB limit is not dropped. If that pushes the tree past the stream cap, the size limit comes back. A checkout without a git index falls back to the names alone.Reading the lines it now reaches
make testthat tells the reader to run a development shell the README shows, reads as depending on that block.goreleaser initrefusing because the repository's own configuration is there, taints the same tool's later lines in that document. Their failures, and any nonzero exit the documents bless, read checkout-state. A usage error or a crash still stands.--exit-code 1, asks for that exit and is read as documented behavior.curl http://nginxafter its skippedkubectllines is the cluster missing, not the guide. A dead domain no such line names still fails.<details>element is a section of its own. A README that offers a template setup and a manual setup side by side under one heading ran both in one shell, so the manual setup met the template's directory. It now reads inherited-state, as a later heading already did.Environment changes
The session asks each documented binary for
--versiononce at the start. After a line that ran one of them exits nonzero, it asks again, only for a binary that passed the first time. A crash followed by a failed probe reads BLOCKED with the new reasonenvironment-changed: something the session ran changed the environment the tool runs from, so the crash says nothing about the line. A crash the tool survives still reads FAIL, and a plain nonzero exit is never read this way.Verification
The jq recall row flips to caught in its own commit. The full reconciliation lane over the corpus and the earlier sweeps runs before merge.