Repository navigation
Add FastVideo MLX engine, compact generation controls and benchmarks - #2
Draft
davidaircloud wants to merge 4 commits into
Draft
davidaircloud wants to merge 4 commits into
davidaircloud wants to merge 4 commits into
Conversation
…easured five-second comparisons
…the generation card boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastVideo is now an optional Apple Silicon video engine in Settings, with managed download, activation, cancellation and removal. Text uses FastH3 Trim; reference images use FastH3 Omni. It complements the existing h3.c and H3MLX engines and switches through the composer model picker.
The adapter pins source, model snapshots and 33 hashed inference dependencies in a separate runtime. Generation uses disposable subprocesses, safetensors, offline Hub flags and local caches. Removal verifies the owned root and receipt. The dependency audit found no known vulnerabilities; this is process/dependency isolation, not an OS sandbox.
Generation controls now use discreet capability messages with a switch action, a styled image-model field, and a compact Shared style disclosure below the prompt (above scenes in storyboard). Disabling style preserves its text. Storyboard selection hides the inactive composer Generate button.
Measured on M5 Max / 128 GB, 512×512, approximately five seconds:
All six clips, the reference image, JSON/CSV provenance and a portable comparison player are in benchmarks/2026-10-26-fastvideo. These are single serial runs using different app presets and distilled models, not a quality-equivalence claim. FastVideo uses eight forwards, M5 NAX attention and reference sizing capped to the output area.
Validation: 304 Python tests passed (one skipped); browser checks passed for capability actions, engine switching, Settings, image selection, style disclosures and storyboard controls. All six report videos loaded at 512×512 with approximately five-second duration. Real installer, text generation and image-reference generation completed locally.
Targets the existing H3MLX/Qwen recovery branch so this PR contains only the FastVideo integration and related UI/benchmark changes. Setup, pinned revisions, limitations, licenses and review findings are in docs/FASTVIDEO_INTEGRATION.md.