feat(extension): configure PII entity types and custom regex from options page#540
Open
yjouini wants to merge 1 commit into
Open
feat(extension): configure PII entity types and custom regex from options page#540yjouini wants to merge 1 commit into
yjouini wants to merge 1 commit into
Conversation
…ions page Wire the Chrome extension options page to the new server-side PII config endpoints introduced in dataiku#509/dataiku#513: - Entity types: GET/POST /api/pii/entities ({available, disabled}), unchecking a type adds it to the disabled (passthrough) set. - Custom patterns: GET/POST /api/pii/regexes, whole-set replacement on each add/remove; custom names appear as selectable entity types. Config is stored server-side, so /api/pii/check needs no per-request label list and background.js is unchanged. Closes dataiku#458, Closes dataiku#459 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458, Closes #459
Wires the Chrome extension options page to the server-side PII config endpoints introduced in #509 / #513. The config UI from #470 is brought over and re-pointed at the new contract; the backend changes in #470 are superseded by #509/#513, so this PR is extension-only.
Entity types (
/api/pii/entities)GET({ available, disabled }). Checked = masked.disabled(passthrough) set viaPOST { disabled: [...] }. A "Disable all / Enable all" toggle is included.400and surfaced inline.Custom patterns (
/api/pii/regexes)name+pattern) with a live match preview before saving.POSTreplaces the whole set, so add/remove rebuild the list and re-POST. Each custom name then appears as a selectable entity type in the grid.Notes
GenericGenerator→[REDACTED_<NAME>_<hash>]. Demasking/substitution for custom types remains open.🤖 Generated with Claude Code