Af tree explorer recipe#100
Open
Ellana42 wants to merge 289 commits into
Open
Conversation
*ability to check/uncheck the attributes * remove recursivity when selecting an element
…r a search * highlight elements when clicking on it from the tree view * clear element input when clicking on an other element from the tree view
*formatting
*put the attributes in a styled table
*add an array of urls for clicked nodes
*template tree
*add select/unselect all *separate template search from element search
node.attribute_children
All objects using attributes reference that structure
Feature/slim down config
watcher to callBack for refreshing displayed attributes
Summary type array + bug fixes
feature/paperclips and breadcrumbs
tdnghia98
reviewed
Jun 12, 2026
| 'mandatory': true | ||
| }; | ||
|
|
||
| $scope.config.attributeList = $scope.config.attributeList || []; // la liste des attributs qui sont affichés sur le main panel à droite |
There was a problem hiding this comment.
Nit: shorthand
Suggested change
| $scope.config.attributeList = $scope.config.attributeList || []; // la liste des attributs qui sont affichés sur le main panel à droite | |
| $scope.config.attributeList ||= []; // la liste des attributs qui sont affichés sur le main panel à droite |
|
|
||
| function buildSelectedAttributesTable() { | ||
| return ($scope.config.outputSelectedAttributes || []) | ||
| .filter(attribute => attribute.checked !== false) |
There was a problem hiding this comment.
Could be loose equality here, so we don't leave null and undefined passing through (even though I don't think there are)
Suggested change
| .filter(attribute => attribute.checked !== false) | |
| .filter(attribute => attribute.checked) |
| } | ||
|
|
||
| $scope.onAdvancedToggle = function() { | ||
| if (!$scope.config.show_advanced_parameters) { |
There was a problem hiding this comment.
Functionally I don't expect a show/hide checkbox to alter the values of config
| if ($scope.config.elements_max_count === null || $scope.config.elements_max_count === undefined || $scope.config.elements_max_count === "") { | ||
| $scope.config.elements_max_count = 100; | ||
| } | ||
| if ($scope.config.attributes_max_count === null || $scope.config.attributes_max_count === undefined || $scope.config.attributes_max_count === "") { |
There was a problem hiding this comment.
Shorter if you like it
Suggested change
| if ($scope.config.attributes_max_count === null || $scope.config.attributes_max_count === undefined || $scope.config.attributes_max_count === "") { | |
| if (!!!$scope.config.attributes_max_count) { |
| </div> | ||
| <div class="pi-system-explorer__content"> | ||
| <pi-system-auth-banner></pi-system-auth-banner> | ||
| <div class="control-group removed-if-manual-query" ng-show="false" ng-if="config.database_name"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.