Repository navigation
feat: embed eager Iceberg assignments in scan inputs - #799
Closed
alexanderbianchi wants to merge 1 commit into
Closed
alexanderbianchi wants to merge 1 commit into
alexanderbianchi wants to merge 1 commit into
Conversation
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eager Iceberg scans currently retain files inside a work-unit feed. Before routing, DFD converts that feed into a remote handle, so the existing routing callback cannot inspect the assigned files.
This draft explores representing eager assignments directly in the scan, while retaining feeds for lazy discovery:
Mechanics
IcebergDataSourceand reader handle both inputs.AssignedFilesexposes borrowed files grouped by local partition.DistributedLeafExecvariants after the final task count is known. Each variant owns a concrete assignment; routing and execution no longer independently calculate it.RouteTaskEvent::task_specialized_planexposes these eager groups directly. No core DFD routing changes, additional plan view, affinity hints, or placement policy are introduced.Stacked on #789. This is an alternative to #797 and #790, intended to compare explicit assigned work with exposing coordinator-local plans to routing. It does not add ordered-read strategies.
Tradeoffs and compatibility
Eager plans carry file descriptors, increasing plan payload size and moving their transport to worker setup. Greedy assignment runs synchronously in the existing scale-up hook. No performance improvement is claimed or benchmarked.
IcebergDataSource::feed()now returnsOption; eager callers inspectassigned_files()orinput(). Coordinators and workers must be upgraded together before using the new eager wire representation. Lazy feed plans keep their existing representation. The upgrade guide documents both changes.Validation