Skip to content

feat(clustering): Enable clustering on inventary layer#174

Open
david-bretaud-dev wants to merge 3 commits into
mainfrom
david-bretaud-dev/fix-zoom-level-on-popup-click
Open

feat(clustering): Enable clustering on inventary layer#174
david-bretaud-dev wants to merge 3 commits into
mainfrom
david-bretaud-dev/fix-zoom-level-on-popup-click

Conversation

@david-bretaud-dev

Copy link
Copy Markdown
Collaborator

PoC, cf PR on coordonnées which contains the complexity: dataforgoodfr/Coordonnees#89

@david-bretaud-dev david-bretaud-dev self-assigned this Jun 25, 2026
@@ -0,0 +1,11 @@
// Façade file to export coordo content
// This helps for local development where only one path has to be updated
export {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to understand why this is helpful

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK about your codebase, but mine is like this:
codebase/14_Data4Trees/
codebase/Coordonnees/

To test a new feature from Coordonnées, I usually change the import path for coordo from coordo to ../../../../Coordonnees/coordo-ts/src (e.g I use my local coordo from my filesystem). Easier before pushing any new tag.

The pain is that if we import coordo from multiplace, sometimes to not have ts issues I have to change the path in different locations, and it's a burden (then to remove).

Here, I'm just making a single entry point to the coordo lib. Usually we do this to create an abstraction call Facade that makes the API usage easier (https://refactoring.guru/design-patterns/facade/typescript/example). It's kind of a facade here, that just re-export stuff 😁

@david-bretaud-dev david-bretaud-dev force-pushed the david-bretaud-dev/fix-zoom-level-on-popup-click branch from 9ede9a8 to 95e79f5 Compare June 28, 2026 20:21
@arnaudfnr

Copy link
Copy Markdown
Collaborator

Need rebase and reinstall coordo 0.6.0 on backend and frontend side (the tag changed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants