Repository navigation
feat: add optional browser annotations with screenshot and element context - #796
Open
agentone666-ship-it wants to merge 5 commits into
Open
agentone666-ship-it wants to merge 5 commits into
agentone666-ship-it wants to merge 5 commits into
Conversation
agentone666-ship-it
marked this pull request as ready for review
October 27, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Adds an optional browser beside the conversation: native sidebar tabs, URL/search navigation, element/region annotations with anchored input, and hold-Space browsing. The composer shows a screenshot review popover. One send carries real image blocks, element/DOM/style evidence and comments; sent messages show a readable summary with optional detailed review.
The plugin is not installed/enabled by default. The only host patch addition is
data-dsh-composer-primary="send" | "stop"on the native primary button. Existing native handlers and slot contracts stay intact; a narrow, documented adapter observes that marker, preserves Stop and disables annotation submission when the marker is unavailable. The marker can be removed when upstream exposes an equivalent public composer submission API.Implementation
packages/dsh-page-review0.4.2 owns its build/lockfile, public sidebar/accessory/chat-node contributions and Cordis lifecycle cleanup.PDF/Word/Markdown preview annotation UI and side-chat/session-mail work are outside this PR. Current main lacks the incoming prototype's legacy preview integration contract; compatible packet/location helpers remain tested.
Validation
npm ci, build, 82/82 tests passed, zero skipped/cancelled. Includes real Chrome lifecycle/reconnection, extracted archive startup, license coverage, reference serialization, readable message projection, admission retry behavior and concurrent attachment retirement. Final 0.4.2 run: 43.5s.git diff --checkis clean.npm testpretest stopped in unchanged Office template verification. No assertions or deadlines were weakened. After unlock, the direct complete Vitest run (using the unchanged earlier template cache after that pretest failure) finished with 2186 passed / 18 failed, 219 files, in 957.2s. Failures were in Office runtime and PPT import/template suites, including timeouts and startup/progress assertions. Those files are unchanged by this PR, but a matching upstream baseline is not established; they are not certified as pre-existing. See the validation record for evidence boundaries.The deterministic local model validates transport and queue mechanics, not a commercial model's visual reasoning. Windows/Linux desktop behavior remains unverified; the optional-package CI matrix is defined, but GitHub reported no check results at the last inspection. Ready for review with these limitations disclosed, not an all-green repository or release certification.
Details:
docs/browser-annotations-validation.md.