Repository navigation
fix(window): 主窗口标题使用应用名,修复 Windows 任务栏无名称 - #795
Merged
yaojin3616 merged 2 commits intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #575
主窗口创建时
title: '',page-title-updated里又setTitle(''),窗口标题一直是空的,Windows 任务栏显示标签时只有图标没有名字。改动:
createWindow用title: app.getName(),page-title-updated仍然preventDefault,改成setTitle(app.getName()),页面标题不会覆盖它build/splash.html补上<title>DSH Desktop</title>,启动页阶段也不是空标题hiddenInset/ Windowshidden+titleBarOverlay不变,界面上不会多出标题文字验证:
test/main-window-title.test.ts(createWindow在入口文件里,导入会启动 Electron,所以按仓库里已有的做法读源码断言),main 上 3/4 失败,改动后 4/4 通过npm test、npm run typecheck在 main 上就有一批环境相关失败(office/ppt/patch 等,typecheck 报错在test/session-delete-remote.test.ts),改动前后失败集合一致git diff --check通过未验证:手头没有 Windows 机器,没在真实任务栏上看过效果。