Repository navigation
Fix generation links removed by unrelated pnpm operations - #549
Open
yaojin3616 wants to merge 4 commits into
Open
yaojin3616 wants to merge 4 commits into
yaojin3616 wants to merge 4 commits into
Conversation
Contributor
Author
|
Failure-path review: pnpm-runner.mjs:344-350 writes the manifest isolation before reading/writing the lockfile. A lockfile error occurs before a restore callback is returned, so this operation can leave the live projection partially isolated. The persistent marker may allow cold-start recovery; this is not a claim of permanent data loss. Please make preparation/restoration transactional for read/write failures and add real-pnpm plus multi-importer/quoted-key cases. Keeping the requirement open; current target runner has no equivalent fix. No real installation or Windows failure injection was executed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- remove generation-owned entries from the pnpm lockfile importer during projection isolation\n- keep generation paths out of pnpm ownership while retaining the market-facing manifest after the operation\n- cover legacy lockfile entries in the pnpm runner regression test\n\nFixes #464\n\n## Verification\n- npm test -- --run test/pnpm-runner.test.js\n- npm test -- --run test/generation-projection.test.ts\n- npm run typecheck (fails on existing test/session-delete-remote.test.ts TypertRemoteNamespace.delete typings)