Repository navigation
Check the type of every nested property on its own line - #1719
Merged
Merged
Conversation
…sted types per level
… lines, and skip nested lines under a mistyped parent with a warning
…ose native types are not read
…clared inside it, and check the type implied by properties, items or a map block
…or-contract # Conflicts: # CHANGELOG.md
nicolehazel
added a commit
to nicolehazel/datacontract-cli
that referenced
this pull request
Oct 13, 2026
Resolve conflicts with datacontract#1719 (per-path nested type checks) and the v1.2.5/v1.2.6 releases: keep the xlsx type check ahead of the new own_type block, take the new schema.md paragraph, and move the changelog entry to Unreleased. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every declared nested property and array item now gets its own presence and type check, replacing the one nested type check per column, and a nested
physicalTypeis compared against the native type read from the catalog (Athena, Trino, Databricks, BigQuery, ClickHouse, Hive, Snowflake) instead of warning that it is not read; importers for those backends declare nested types once, per level. Verified against Athena, Snowflake, Databricks and BigQuery, and the Trino, Hive and ClickHouse containers.