Skip to content

Added version check for CSCwd37387 #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muthu-ku wants to merge 5 commits into
base: v4.1.0-dev
Choose a base branch
from
Open

Added version check for CSCwd37387 #378

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b46fea
added version c heck for
muthu-ku Apr 7, 2026
31eabfc
Merge branch 'v4.1.0-dev' of github.com:muthu-ku/ACI-Pre-Upgrade-Vali…
muthu-ku Apr 9, 2026
3174b1f
updated document link
muthu-ku Apr 10, 2026
fea3517
updated validation.md
muthu-ku Apr 10, 2026
bd01f56
updated validation.md document
muthu-ku Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions aci-preupgrade-validation-script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3917,9 +3917,6 @@ def llfc_susceptibility_check(cversion, tversion, vpc_node_ids, **kwargs):
recommended_action = 'Manually change Peer devices Transmit(send) Flow Control to off prior to switch Upgrade'
doc_url = 'https://bst.cloudapps.cisco.com/bugsearch/bug/CSCvo27498'

if not tversion:
return Result(result=MANUAL, msg=TVER_MISSING)

if not vpc_node_ids:
return Result(result=PASS, msg="No VPC Nodes found. Not susceptible.")

Expand All @@ -3928,7 +3925,8 @@ def llfc_susceptibility_check(cversion, tversion, vpc_node_ids, **kwargs):
sx_affected = True

# Check for Copper 1000base-T, CSCvj67507 fixed by CSCwd37387
if cversion.older_than("4.1(1i)") and tversion.newer_than("4.1(1h)") and tversion.older_than("5.2(7f)"):
if ((cversion.older_than("4.1(1i)") or cversion.same_as("4.1(1i)")) and tversion.older_than("5.2(7f)") and tversion.newer_than("4.0(1h")) or (cversion.older_than("5.2(7f)") and tversion.newer_than("5.2(7f)")
or (tversion.older_than("5.2(7f)") and cversion.same_as(tversion))):
t_affected = True

if sx_affected or t_affected:
Expand Down
28 changes: 21 additions & 7 deletions tests/checks/llfc_susceptibility_check/test_llfc_susceptibility_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,27 @@
@pytest.mark.parametrize(
"icurl_outputs, cversion, tversion, vpc_node_ids, expected_result",
[
(
{ethpmFcots: read_data(dir, "ethpmFcot.json")},
"5.2(5c)",
"6.1(5e)",
["101", "103", "204", "206"],
script.MANUAL,
),
(
{ethpmFcots: read_data(dir, "ethpmFcot.json")},
"4.1(1i)",
"5.2(2a)",
["101", "103", "204", "206"],
script.MANUAL,
),
(
{ethpmFcots: read_data(dir, "ethpmFcot.json")},
"5.2(7f)",
"6.1(5c)",
["101", "103", "204", "206"],
script.PASS,
),
(
{ethpmFcots: read_data(dir, "ethpmFcot.json")},
"4.2(1b)",
Expand Down Expand Up @@ -53,13 +74,6 @@
["101", "103", "204", "206"],
script.PASS,
),
(
{ethpmFcots: read_data(dir, "ethpmFcot.json")},
"5.2(1a)",
None,
["101", "103", "204", "206"],
script.MANUAL,
),
(
{ethpmFcots: read_data(dir, "ethpmFcot.json")},
"4.1(1a)",
Expand Down
Loading