ci(docs): bump pages actions to v5 (SHA-pinned deps) - #806
Merged
Merged
Conversation
upload-pages-artifact@v3.0.1 internally calls actions/upload-artifact@v4 via an unpinned tag, which ontos policy rejects. v5.0.0 pins its internal upload-artifact to a SHA; pair it with deploy-pages@v5.0.1 for the matching artifact backend. Both remain pinned to full-length commit SHAs. Co-authored-by: Isaac <no-reply@databricks.com>
mvkonchits-db
approved these changes
Sep 11, 2026
mvkonchits-db
left a comment
mvkonchits-db
left a comment
Contributor
There was a problem hiding this comment.
Reviewed with the code-review skill lens — clean, approving. This consolidates both GitHub Pages actions into one SHA-pinned bump: upload-pages-artifact v3.0.1→v5.0.0 (fc324d3) and deploy-pages v4.0.5→v5.0.1 (368f825), which is the compatible v5/v5 pairing. Both SHAs match the tags in the trailing comments, and this supersedes the individual Dependabot PRs #798 (upload-pages-artifact→v5) and #803 (deploy-pages→v5), which I'm closing in favor of this. Deliberately leaves setup-node/checkout at v4 (the #799/#802 majors are a separate decision). CI green.
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Second follow-up to the Pages deploy. After pinning the top-level actions to SHAs, the build still failed:
That's a transitive ref:
upload-pages-artifact@v3.0.1internally callsactions/upload-artifact@v4via an unpinned tag, which the policy rejects even though our top-level pin was a SHA.Fix — bump both Pages actions to v5, which pin their internal deps to SHAs:
actions/upload-pages-artifact→fc324d3547104276b827a68afc52ff2a11cc49c9(v5.0.0) — internalupload-artifactis SHA-pinned to v7.0.0actions/deploy-pages→368f82528645a54fb793d4d04e342629a3f51346(v5.0.1) — matching artifact backend, no internaluses:After merge
Push to
developmentre-triggers the workflow (or runworkflow_dispatch), which should now build and publish to https://databrickslabs.github.io/ontos/.This pull request and its description were written by Isaac.