Require feedback before disabling Smart Router in Isaac by JJ27 · Pull Request #1139 · databricks/unity-gateway

JJ27 · 2026-10-15T18:58:25Z

What did you change, and why?

Require a reason before turning Smart Router off in Isaac sessions with ISAAC_SMART_ROUTER_FEEDBACK=1. The reason must contain at least 16 characters after trimming surrounding whitespace. Cancel or Escape keeps routing on. Each new on-to-off transition requires feedback.

The native Claude form validates locally, then disables routing and passes the exact user text to /isaac-feedback --category smart-routing. Opening or cancelling the form makes no model calls. If the command or form is unavailable, routing stays on. Once a valid reason is accepted, a submission failure is reported and leaves routing off.

The CLI validates the same minimum through --smart-router-feedback; the bundled Claude/Codex skill asks for the reason and handles submission. Routing toggles preserve Isaac's rollout flag. Sessions outside the rollout retain their existing behavior.

Requires the shared session flag and argument handling in https://github.com/databricks-eng/universe/pull/2806823.

How do you know it works?

211 focused Python checks passed for session controls, packaged mods, and routing configuration. The required-reason regression fails against the previous implementation.
Claude Code 2.1.290 plugin validation and native component checks passed, including 13 TypeScript cases. Coverage includes the 15/16-character boundary, surrounding whitespace, Unicode, exact text, cancellation, repeated toggles, and failures.
Ruff check, Ruff format check, and ty passed.
A native Claude Code 2.1.290 terminal check passed: Escape left routing on without submission, 15 characters were rejected, 16 were accepted and delivered unchanged, and re-enabling then disabling required a fresh reason. It verified the real CLI session controls and exited normally. The receiver was local; this does not establish a live evidence upload or macOS coverage.

What it looks like

smart-router-feedback-pr1139-color.mp4

JJ27 · 2026-10-15T22:27:26Z

 skill to further work only if the session was launched with `ENABLE_SMART_ROUTER_ORCHESTRATOR=1`.
 Do not change the orchestration feature flag. Return the command's result.
+If the result includes the optional `/isaac-feedback` invitation, show it at most
+once in this session. Do not wait for feedback or submit it automatically.


@lilly-luo currently set to 'at most once per session', should we do this every time smart router is manually toggled off?

Copilot