Normalize bare hosts to HTTPS - #317
Open
parthban-db wants to merge 1 commit into
Open
Conversation
parthban-db
force-pushed
the
parthban-db/stack/sdk-js-fix-1
branch
from
September 4, 2026 09:57
ea5d4ab to
144f0f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
Normalizes Databricks hosts at the generated transport boundary so every modular service client accepts scheme-less
ClientOptions.host, configuration-profile host, andDATABRICKS_HOSTvalues.Why
Generated clients previously concatenated the configured host into request URLs without ensuring it was absolute. A bare host such as the value commonly supplied through
DATABRICKS_HOSTtherefore reachedfetchas a relative URL and failed withTypeError: Invalid URL, forcing consumers such as AppKit to normalize the host themselves.What changed
Interface changes
ClientOptions.hostnow documents that HTTPS is used when the scheme is omitted; its TypeScript shape is unchanged.Behavioral changes
https://when no HTTP(S) scheme is present, preserve explicit HTTP(S), and remove the trailing slash.Internal changes
How is this tested?
npm run build,npm run lint,npm run format:check,npm run typecheck, andnpm testpass. The 298 browser tests in the browser-bearing packages also pass against the system-installed Chrome.