Skip to content

Make DCO check more developer friendly #519

Closed
Closed
Make DCO check more developer friendly#519
Assignees
madhav-db

Description

@samikshya-db
samikshya-db
opened on Feb 27, 2025

DCO tests in GitHub Actions ensure code contributions are legally sound. We are implementing stricter DCO checks. Currently, DCO compliance is not enforced as a pre-merge requirement.

Sample PR where DCO passes : https://github.com/databricks/databricks-sql-python/pull/461/commits.

But, sadly the sign-off should be part of every commit message for DCO GH action to pass. The idea is to make it more developer friendly.

Activity

  1. madhav-db
    self-assigned this
    on Feb 27, 2025

  2. dhirschfeld commented on Feb 27, 2025

    @dhirschfeld
    dhirschfeld
    on Feb 27, 2025
    Contributor

    I suppose it's theoretically possible to rewrite history to add a Signed-off-by to a merge commit, but I don't think that really makes much sense and it would be better for the check to ignore merge commits.

  3. dhirschfeld commented on Feb 27, 2025

    @dhirschfeld
    dhirschfeld
    on Feb 27, 2025
    Contributor

    The DCO check does appear to be broken though:

  4. vikrantpuppala commented on Jul 8, 2026

    @vikrantpuppala
    vikrantpuppala
    on Jul 8, 2026
    Contributor

    Fixed in #769

  5. vikrantpuppala
    closed this as completedon Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions