Repository navigation
chore(kernel): bump SQL kernel to 1.2.0 - #502
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
vuanhphung
added
ai-assisted
integration-test-kernel
|
Go integration tests triggered ( |
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Straightforward kernel bindings bump to v1.2.0 — KERNEL_REV, go.mod, and go.sum are internally consistent, and the three new header symbols are additive (not yet wired into Go, which is fine). One low-severity doc-staleness note: the header's kernel_statement_execute comment dropped the "600-second polling ceiling," but two Go doc comments still assert it.
| /* | ||
| * Wait-for-result execution with the existing 600-second polling ceiling and | ||
| * no caller-supplied deadline. On success, release `*out` with | ||
| * Wait-for-result execution without an overall client polling deadline. |
There was a problem hiding this comment.
🔵 Low — This header sync changes the documented behavior of kernel_statement_execute: v1.1.0 said "the existing 600-second polling ceiling and no caller-supplied deadline," and v1.2.0 now says "without an overall client polling deadline." The driver's own Go doc comments still describe the old behavior and are now stale:
config.go:33-34: "nil uses kernel_statement_execute and retains its legacy 600s polling ceiling"operation.go:266: "nil invokes the legacy API (and its existing 600s polling ceiling)"
Both comments now contradict the header shipped in this PR. A reader relying on them would believe that omitting ClientQueryTimeout caps execution at 600s, when per the updated kernel the legacy path no longer imposes that ceiling. Behavior of the Go code is unchanged (the routing logic doesn't depend on the ceiling), so this is documentation-only — but it should be updated alongside the header bump to avoid misleading the next reader.
1 participant
Update all seven platform bindings to v1.2.0 so kernel-mode consumers use the released SQL kernel. Pin KERNEL_REV to the v1.2.0 source commit and sync the committed C header from that tag.
Validated the full local pure-Go and kernel-tagged suites against the published archive, module checksums, and exact header match. CI passes on Go 1.25/1.26, including race checks and builds, plus the kernel backend and warehouse integration suite (140 passed, 125 skipped).