Skip to content

fix: default geospatial results to strings - #501

Merged
cathleeny merged 2 commits into
mainfrom
cathleeny/geospatial-default-off
Oct 19, 2026
Merged

cathleeny merged 2 commits into
mainfrom
cathleeny/geospatial-default-off

Conversation

@cathleeny

@cathleeny cathleeny commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Default enableGeoSpatialSupport to false so kernel connections, including automatic Reyden recovery, retain WKT/EWKT strings. Explicit true still returns native geospatial results.
  • Update documentation and default-mode unit/E2E expectations. No kernel pin changes.

Validation

  • Full Go unit suites passed with and without the kernel build tag.
  • Live staging Reyden/DBSQL: all 48 cases passed value checks in omitted, false, and true modes through rows and Arrow; every large result checked all 150,007 rows with external delivery confirmed. Small Go/DBSQL statements auto-close, preventing post-execution wire inspection.
  • Dedicated driver E2E passed all three modes on both warehouses. Reyden/DBSQL comparator differences are limited to raw Arrow nullability.

Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
@cathleeny
cathleeny marked this pull request as ready for review October 19, 2026 20:47

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@cathleeny
cathleeny enabled auto-merge October 19, 2026 21:25
@cathleeny
cathleeny disabled auto-merge October 19, 2026 21:25
@cathleeny
cathleeny added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 650af83 Oct 19, 2026
13 checks passed
@cathleeny
cathleeny deleted the cathleeny/geospatial-default-off branch October 19, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant