mason: expose app scaling and sticky routing - #515
Open
shivam5 wants to merge 1 commit into
Open
Conversation
| help="Workspace destination for the synced source (defaults to a per-user path).", | ||
| ) | ||
| @click.option( | ||
| "--compute-min-instances", |
Contributor
There was a problem hiding this comment.
nit: should we shorten to just --min-instances?
elainewang-db
left a comment
elainewang-db
left a comment
Contributor
There was a problem hiding this comment.
were you able to test this live and deploy updates the apps scaling properly? my claude hit some issues with this, not sure if it was an apps side blocker or my own setup
jamesbxwu
reviewed
Sep 2, 2026
| help="Workspace destination for the synced source (defaults to a per-user path).", | ||
| ) | ||
| @click.option( | ||
| "--compute-min-instances", |
Comment on lines
+378
to
+384
| help="Minimum number of Databricks Apps instances. Must be set with --compute-max-instances.", | ||
| ) | ||
| @click.option( | ||
| "--compute-max-instances", | ||
| type=click.IntRange(min=1), | ||
| default=None, | ||
| help="Maximum number of Databricks Apps instances. Must be set with --compute-min-instances.", |
There was a problem hiding this comment.
typo?
Suggested change
| help="Minimum number of Databricks Apps instances. Must be set with --compute-max-instances.", | |
| ) | |
| @click.option( | |
| "--compute-max-instances", | |
| type=click.IntRange(min=1), | |
| default=None, | |
| help="Maximum number of Databricks Apps instances. Must be set with --compute-min-instances.", | |
| help="Minimum number of Databricks Apps instances. Must be set with --compute-min-instances.", | |
| ) | |
| @click.option( | |
| "--compute-max-instances", | |
| type=click.IntRange(min=1), | |
| default=None, | |
| help="Maximum number of Databricks Apps instances. Must be set with --compute-max-instances.", |
Contributor
There was a problem hiding this comment.
can we also remove Apps references?
| __Host-databricks-app-router=<uuid> | ||
| """ | ||
| _validate_deployment_name(name) | ||
| compute_args = _compute_scaling_args(compute_min_instances, compute_max_instances) |
There was a problem hiding this comment.
does the apps runtime support both min and max count today even though they don't support autoscaling yet?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--compute-min-instancesand--compute-max-instancestomason deploymason deploy --helpHelp output
Testing
uv run pytest -q(225 passed)uv run ruff checkuv run ruff format --checkuv run ty checkuv run mason deploy --help