Repository navigation
Fixed immutable folder failing with DMS or top level permissions - #7001
Open
andrewnester wants to merge 3 commits into
Open
andrewnester wants to merge 3 commits into
andrewnester wants to merge 3 commits into
Conversation
Collaborator
Integration test reportCommit: 9200508
Top 3 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Oct 9, 2026
|
|
||
| // immutableSnapshotPath returns the workspace path of the immutable folder snapshot. The | ||
| // snapshot is not uploaded yet at this point, but its content-addressed path is already known. | ||
| func immutableSnapshotPath(b *bundle.Bundle) (string, error) { |
Contributor
There was a problem hiding this comment.
seems a bit weird to read it from state here? Is this something we can store and read from the *bundle.Bundle object instead?
| ] | ||
|
|
||
| # The snapshot path is content-addressed. | ||
| [[Repls]] |
Contributor
There was a problem hiding this comment.
if the hash is deterministic, should we consider removing this repl? Helps assert the metadata being recorded is indeed the right path.
If this causes issues across operating systems, we can limit this test to just linux. WDYT?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed
experimental.immutable_folderfailing withexperimental.deployment_history("workspace_info.file_path must be an absolute workspace path") and failingbundle validatewhen top-levelpermissionsare set.Why
These paths are resolved later during the deployment phase and hence were not correct
Fixes #6960
Tests
Added acceptance tests