Repository navigation
Conversation
denik
added this pull request to stack #6997
October 9, 2026 09:13
Collaborator
Integration test reportCommit: 690c808
Top 3 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/diag-auto-locations
branch
from
October 9, 2026 10:44
cc2ab1c to
b84c6b6
Compare
denik
force-pushed
the
denik/diag-auto-locations
branch
from
October 9, 2026 11:19
b84c6b6 to
b6e292c
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Locations are filled in from paths when the diagnostics are logged, after sorting, so order by path (deterministic) and keep locations as a tie breaker. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…ocation Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/diag-auto-locations
branch
from
October 9, 2026 11:29
b6e292c to
5df9261
Compare
- compute_id warning keeps its location explicitly: the key is deleted before the diagnostic is logged. - Diagnostics about an effective value (invalid engine, trigger_pause_status, name_prefix) keep only its effective location; the automatic lookup would add the overridden ones. - validateJobTask no longer needs the bundle. Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
logdiag.LogDiagfills a diagnostic'sLocationsfrom itsPathswhen they are not set. The bundle installs the lookup (config.Root.GetLocationsOf, nearest ancestor) when it is loaded, so locations reflect the configuration at the time the diagnostic is logged.Locationsthat only repeated their path (31 sites), and 20 configuration diagnostics that had onlyLocationsnow report theirPathstoo.Locationsremain for diagnostics that point elsewhere on purpose (e.g. secret scope permissions point at the scope) or have no configuration path (YAML parse errors, Python sources, files).User-visible: those diagnostics gain an
at <path>line, and two gain anin <file>line;volume_defaults/secret_scope_required_principallist same-summary warnings by path (v1, v2, v3) instead of by location string.Why
PathsandLocationswere computed separately for the same value at most call sites.Stacked on #6984.
This pull request and its description were written by Isaac.