Repository navigation
diag: own Location (move from libs/dyn) - #6974
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: c9b732f
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 7, 2026 12:30
denik
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 7, 2026 13:15
denik
force-pushed
the
denik/diag-location-structpath
branch
from
October 7, 2026 13:23
c8121ae to
8b3a26a
Compare
denik
force-pushed
the
denik/diag-location-structpath
branch
from
October 7, 2026 14:29
30536d2 to
3afe070
Compare
denik
changed the title
denik
force-pushed
the
denik/diag-location-structpath
branch
5 times, most recently
from
October 8, 2026 07:50
53d29f7 to
4be88ef
Compare
denik
force-pushed
the
denik/diag-location-structpath
branch
3 times, most recently
from
October 8, 2026 11:57
c17b428 to
87a5a1d
Compare
denik
force-pushed
the
denik/diag-location-structpath
branch
from
October 8, 2026 16:20
87a5a1d to
d4aea66
Compare
denik
force-pushed
the
denik/diag-location-structpath
branch
from
October 8, 2026 16:35
d4aea66 to
52ca95b
Compare
denik
added this pull request to stack #6997
October 9, 2026 08:18
pietern
approved these changes
Oct 9, 2026
Move Location from libs/dyn to libs/diag and use diag.Location directly, so libs/diag no longer imports libs/dyn. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/diag-location-structpath
branch
from
October 9, 2026 08:39
52ca95b to
c9b732f
Compare
andreamatt
pushed a commit
to andreamatt/databricks-cli
that referenced
this pull request
Oct 9, 2026
## Changes
`diag.Diagnostic.Paths` is `[]*structpath.PathNode` instead of
`[]dyn.Path`. Producers convert existing dyn paths with
`dyn.ToStructPaths` or build paths from keys with
`structpath.NewStringKeys`/`NewStringKeysSlice`/`MustParsePaths`.
`structpath.PureReferenceToPath` moves to
`dynvar.PureReferenceToStructPath` so structpath does not import dyn.
User-visible: diagnostic paths quote map keys that are not identifiers,
e.g. `resources.jobs['${var.env}_job']` instead of
`resources.jobs.${var.env}_job` (one golden).
## Why
First step of removing `libs/dyn` from bundle configuration: databricks#6974 moves
`Location` to `libs/diag` on top of this (it needs diag to no longer
import dyn), then databricks#6954.
This pull request and its description were written by Isaac.
---------
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 4e0f463
20 interesting tests: 12 FAIL, 8 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Locationmoves fromlibs/dyntolibs/diag; callers usediag.Locationdirectly.libs/diagno longer importslibs/dyn.Why
Stacked on #6980 (diagnostic paths use structpath, which removes diag's other dependency on dyn). Prep for #6954, which removes
libs/dynfrom bundle configuration.This pull request and its description were written by Isaac.