Repository navigation
[ZeroOps bug bash] Revise batch-size fix to 250 - #173
Closed
lennartkats-db wants to merge 2 commits into
Closed
lennartkats-db wants to merge 2 commits into
lennartkats-db wants to merge 2 commits into
Conversation
RCA: The job parameter batch_size had a default of "0", which always failed the notebook's positive-integer validation guard (batch_size <= 0), raising ValueError: Invalid job configuration: batch_size must be greater than zero, found 0. Every run of failing_job_example_invalid_configuration (job 468689111693690, run 877581889109114) failed at validate_configuration with no way to recover until the default was corrected. Change: Updated default from "0" to "250" in knowledge_base/failing_job_examples/resources/invalid_configuration.job.yml. The notebook's int() cast and `if batch_size <= 0` guard are preserved unchanged. Only this one YAML file is committed. Base branch for PR: lennart.kats/improve-zeroops-failure-examples Incident: cf869370-f9ae-4435-9969-2fd06c81b8d2 Created using Genie ZeroOps
Extract the integer-parsing and positive-value guard from the top-level
cell in knowledge_base/failing_job_examples/src/invalid_configuration.py
into a reusable parse_positive_batch_size(value) helper with a short
docstring.
Both error messages are preserved verbatim:
- "batch_size must be an integer, found {value!r}"
- "batch_size must be greater than zero, found {batch_size}"
The `from None` suppression on the except branch is retained. Call-site
behaviour is unchanged: batch_size ends up as a validated int in scope.
batch_size default remains "250" from the preceding commit.
Incident: cf869370-f9ae-4435-9969-2fd06c81b8d2
Created using Genie ZeroOps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZeroOps bug-bash experiment. Do not merge or deploy this change.
The failing-job example intentionally sets batch_size to 0. ZeroOps initially suggested 1. In conversation, we requested 250 instead; ZeroOps pushed commit e66424c. We then requested a small parsing helper with the same validation errors; ZeroOps pushed 1e2a130 to this same branch, updating this PR.
Verified: the PR diff contains only the job YAML and notebook source. The remote YAML uses 250. A local test against the remote helper passed for 250, zero, and noninteger input. No Databricks rerun of the proposed fix was performed; the deployed demonstration job intentionally remains failing.
ZeroOps generated and pushed the branch, but returned a GitHub PR-creation URL rather than opening a PR itself. Codex opened this draft PR manually because the debug browser was signed out of GitHub. Base is the published failing-examples branch, keeping the diff scoped to this case.