Repository navigation
chore(management): drop the unused hbbr-local HTTP endpoints - #62
Merged
Merged
Conversation
The hbbr-local management endpoints (GET /v1/sessions, DELETE /v1/sessions/:uuid) and the optional local listener startup came from the original per-service API design. Since the relay control channel aggregates every relay behind the hbbs proxy endpoints (/v1/relays/:id/*) and Console only talks to the hbbs API, nothing consumes the hbbr listener anymore. Keep initializing the managed state for the control channel but never bind a local listener on hbbr, and update the documentation accordingly.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Console server-management v2 rework (#439 in rustdesk-console, #59 here): the per-service management API design from #52 kept an optional local HTTP listener and direct session endpoints on hbbr, but nothing consumes them anymore — Console talks to a single upstream (the hbbs management API) and every relay is aggregated behind the
/v1/relays/:id/*proxy endpoints over the outbound control channel.GET /v1/sessionsandDELETE /v1/sessions/:uuidhandlers and their routes (sessions_snapshot/disconnect_sessionstay: the control channel uses them).init_managed_statebecause the control channel's proxied requests need the state.docs/management.mdto state that the HTTP API is served by hbbs only.What stays from #52
.dockerignore(used by the docker build contexts),management-schema.json(compiled in viainclude_str!and backing/v1/config) and the hbbs management API itself remain in use;docker-managed/and its CI job were already dropped in #61.Validation
cargo check --locked --all-features --all-targetsandcargo test --locked --all-featurespass locally (48 tests). No Console-side change is required: it never calls the removed endpoints.