fix(dashmate): use live Tenderdash app version for protocol status

[thepastaclaw]

Issue being fixed or feature implemented

After an in-process Platform protocol upgrade, dashmate status platform kept reporting a stale Protocol Version from Tenderdash node_info.protocol_version.app (snapshotted at process start), while live RPC fields already reflected the activated version. That made healthy upgraded nodes look stuck on the previous protocol during rollout windows.

Fixes #4135

What was done?

• Source Protocol Version (active/current) from Tenderdash /status application_info.version instead of stale node_info.protocol_version.app.
• Keep Desired Protocol Version (installed/supported) from /abci_info app_version.
• Fall back with optional chaining / ?? to node_info.protocol_version.app only when application_info (or its version) is omitted — Tenderdash uses json:",omitempty" and leaves the field empty when ABCIInfo fails — so status does not TypeError into serviceStatus: error.
• Update unit fixtures so live application_info.version still wins when present even if node_info.protocol_version.app is intentionally stale; add focused coverage for missing application_info.

How Has This Been Tested?

• Focused Dashmate unit tests: yarn workspace dashmate mocha --require ./test/bootstrap.js test/unit/status/scopes/platform.spec.js → 8 passing
• Dashmate lint: yarn workspace dashmate lint → 0 errors (existing warnings only)
• CodeRabbit thread on missing application_info: validated against Tenderdash ResultStatus/Status implementation; fallback applied while preserving dashmate status platform reports stale "Protocol Version" after protocol upgrade activation (node_info.protocol_version.app frozen at process start) #4135 live-field preference

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

[coderabbitai]

📝 Walkthrough

Walkthrough

Dashmate platform status now derives Tenderdash’s protocol version from application_info.version rather than the process-start snapshot in node_info.protocol_version.app. Unit-test mocks are updated with live application versions.

Changes

Protocol version reporting

Layer / File(s)	Summary
Use live protocol version in platform status packages/dashmate/src/status/scopes/platform.js, packages/dashmate/test/unit/status/scopes/platform.spec.js	getTenderdashInfo reads the live application version, with comments documenting the distinction from the snapshotted node protocol version; affected test fixtures now include application_info.version.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: quantumexplorer

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The code and tests match #4135 by sourcing the current protocol version from application_info.version while preserving the desired version path.
Out of Scope Changes check	✅ Passed	The PR appears scoped to the protocol-version fix and its regression tests, with no unrelated changes evident.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: using the live Tenderdash app version for protocol status in dashmate.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/dashmate/src/status/scopes/platform.js`:
- Around line 147-151: Update the protocolVersion assignment near the
application_info status handling to safely read application_info.version with
optional chaining and fall back to node_info.protocol_version.app when
application_info is absent or its version is unavailable, while preserving
numeric parsing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8945dc9d-24a9-43d0-9276-f096a91edfed

📥 Commits

Reviewing files that changed from the base of the PR and between dc1d645 and 5542624.

📒 Files selected for processing (2)

• packages/dashmate/src/status/scopes/platform.js
• packages/dashmate/test/unit/status/scopes/platform.spec.js