-
Notifications
You must be signed in to change notification settings - Fork 56
feat(kotlin-sdk): split build/broadcast with reservation release for BIP70-style deferred submission #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bfoss765
wants to merge
7
commits into
dashpay:feat/kotlin-sdk-and-example-app
Choose a base branch
from
bfoss765:feat/kotlin-sdk-split-build-broadcast
base: feat/kotlin-sdk-and-example-app
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(kotlin-sdk): split build/broadcast with reservation release for BIP70-style deferred submission #4090
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e3df6b2
feat(kotlin-sdk): split build/broadcast with reservation release for …
bfoss765 e09546d
fix(kotlin-sdk): bound deferred-payment token lifetime; harden regist…
bfoss765 bbcd88e
fix(kotlin-sdk): resolve rebase semantic conflicts onto feat/kotlin-s…
bfoss765 b83cdcb
fix(kotlin-sdk): assert native code 26 for the stale-reservation-toke…
bfoss765 fe3f59a
fix(kotlin-sdk): bound the deferred-payment token on the reservation'…
bfoss765 70f11b3
fix(kotlin-sdk): sweep deferred-payment tokens only when the final wa…
bfoss765 84ef267
fix(kotlin-sdk): route deferred builds through the atomic finalize-an…
bfoss765 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Suggestion: registerSignedPayment stitches two native round-trips in Kotlin, contrary to this repo's kotlin-sdk rule
registerSignedPaymentcallscoreTransactionGetBytes(tx.handle)and thencoreWalletRegisterSignedPayment(...), stitching the two results into oneSignedCoreTransactionwith hand-rolledByteBufferdecoding.packages/kotlin-sdk/CLAUDE.mdstates explicitly: "No JNI functions that stitch together existing Rust calls — add the composite to Rust instead." Confirmedcore_wallet_transaction_get_bytes/coreTransactionGetByteshas exactly one Kotlin call site — this one — so there's no other caller relying on it staying separate.core_wallet_signed_payment_register(rs-platform-wallet-ffi/src/core_wallet/signed_payment.rs:84) already has(*tx).bytes()in scope (it uses it to deserialize the transaction at line 100); it could copy those bytes into an additional out-parameter and return everything in one native round trip, removingcoreTransactionGetBytesfrom this path entirely.source: ['claude']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in
a428f54— registerSignedPayment stitches two native round-trips in Kotlin, contrary to this repo's kotlin-sdk rule no longer present.Auto-resolved by the review system based on the latest commit diff. If you believe this was closed in error, reopen the thread.