Skip to content

refactor: clean up governance inv tests after request cache removal #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 4 commits into from
Jul 20, 2026
Merged

refactor: clean up governance inv tests after request cache removal #7449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97abde6
test: reuse the peer helper in per_object_vote_sync_is_fulfilled_requ…
thepastaclaw Jul 12, 2026
83d8dd7
test: drop the governance inv fixture setup left over from CheckAndRe…
thepastaclaw Jul 12, 2026
a8f2711
refactor(governance): move RELIABLE_PROPAGATION_TIME next to its only…
thepastaclaw Jul 12, 2026
2673240
test: extract AssertMisbehaviorScore helper in governance inv tests
thepastaclaw Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/governance/governance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ namespace {
constexpr std::chrono::seconds GOVERNANCE_DELETION_DELAY{10min};
constexpr std::chrono::seconds GOVERNANCE_ORPHAN_EXPIRATION_TIME{10min};
constexpr std::chrono::seconds MAX_TIME_FUTURE_DEVIATION{1h};
using governance::RELIABLE_PROPAGATION_TIME;
// Margin below MAX_TIME_FUTURE_DEVIATION so lagging-clock peers don't reject near-limit objects.
constexpr std::chrono::seconds RELIABLE_PROPAGATION_TIME{60};
Comment thread
thepastaclaw marked this conversation as resolved.

bool IsSyncableObject(const std::shared_ptr<CGovernanceObject>& govobj)
{
Expand Down
3 changes: 0 additions & 3 deletions src/governance/governance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <primitives/transaction.h>
#include <sync.h>

#include <chrono>
#include <limits>
#include <map>
#include <memory>
Expand Down Expand Up @@ -39,8 +38,6 @@ class UniValue;

namespace governance {
class SuperblockManager;
// How long a requested governance inv hash remains in the request cache.
inline constexpr std::chrono::seconds RELIABLE_PROPAGATION_TIME{60};
} // namespace governance

using vote_time_pair_t = std::pair<CGovernanceVote, int64_t>;
Expand Down
Loading
Loading