Repository navigation
refactor: split SessionEscrow.swift into one file per type (INC-495) - #543
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure move, no behavior change. SessionEscrow.swift was 2,453 lines holding six unrelated types, which made it slow to navigate and review. Each type now has its own file: SessionEscrowPolicy, HolderRetrieveDecision, EscrowWireFormat, UnixDomainFDPassing, SessionEscrowClient (with its extension) and SessionEscrowHolder. SessionEscrow.swift keeps the overview doc comment.
Checked: a sorted line diff of non-import, non-blank lines against main is identical (2,322 lines). The project file has the four entries for each new Swift file.
Fixes INC-495