Repository navigation
fix: keep worktrees with ignored local files out of automatic cleanup (INC-486) - #541
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background worktree cleanup only protected ignored
.envfiles, so other ignored local state was deleted along with the worktree:.claude/settings.local.json,.dev.vars, local databases, and nested clones with unpushed commits.Automatic cleanup now keeps any worktree that holds an ignored file outside the known build and dependency folders (
node_modules,build,.build,DerivedDataand similar). It rechecks right before removing. If git can't answer, the worktree is kept. The background pass also skips these git probes for worktrees it already keeps for cheaper reasons.Manual cleaning from the Storage panel or the CLI is unchanged.
Tests: new tests with real temp repos, plus settings default and clamp tests. Not run in a running app.
Fixes INC-486
CI fix: the nested-repository check counted directories that git lists as
dir/as ignored .env files, which failed two tests. They are no longer counted.