Repository navigation
fix: instant Cmd+B sidebar toggle and Reduce Motion in the focus flash (INC-490) - #537
Merged
Merged
Conversation
…springs for retargeted motion (INC-490)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmd+B now toggles the sidebar instantly. Clicks and the command palette still slide it. With Reduce Motion on, every sidebar toggle is instant.
The focus flash does a single short pulse under Reduce Motion, eases out its fades, and a retrigger starts from the ring's current brightness instead of snapping. Sidebar scroll, the drop placeholder, the find bar snap and Show more now use springs, so rapid retargets blend instead of jumping. The flash glow gets an explicit stroked shadowPath.
Intentional test contract change: the FocusFlashPattern curves are now all easeOut, so three pinned assertions in WindowAndDragTests are updated to match.
Not seen running. No feel-check and no Instruments pass yet.
Fixes INC-490