Repository navigation
fix: keep panes alive when an app launched from one is force-quit (INC-384) - #502
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force quitting an app launched from a Programa pane (from the Dock) used to kill Programa and every pane. macOS counted every pane process as part of Programa, so it took them all down together.
Pane commands now start as their own "responsible process", using the same private macOS call iTerm2 uses, with an execve fallback. The submodule bump (ghostty 7e4b75eef) carries the change, and docs/ghostty-fork.md has a new section 13 describing it.
Checked by hand on a tagged build. Before the fix, force quitting a test app launched from a pane killed the app, both panes and their sleep processes. After it, only the test app died.
One visible side effect: panes no longer inherit Programa's privacy permissions. The first time a pane reads ~/Desktop, ~/Documents or ~/Downloads, macOS shows a permission prompt (confirmed). This ships always on, by decision.
The GhosttyKit checksum for the new SHA is added in a follow-up commit once the build-ghosttykit workflow publishes the asset, so macOS CI will fail until then.
Fixes INC-384