Repository navigation
fix: deliver kitty OSC 99 notifications - #442
Merged
Merged
Conversation
The fork had the OSC 99 parser file but no dispatch to it, so kitty notifications were dropped. Pins the fork commit that wires it in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kitty desktop notifications (OSC 99) now reach Programa. The fork had the OSC 99 parser file, but nothing in the OSC state machine reached it, so every OSC 99 sequence was dropped. The fork notes said it was wired up.
The fork commit a6d95cc23 (branch
programa/kitty-osc99, cut from the current pin) adds the99state back. It also ports the parser to the newer capture API and emits the sameshow_desktop_notificationcommand that OSC 9 and 777 use, so the app side needs no change. The fork's OSC unit tests pass (350 pass, 1 skip).This PR moves the submodule pointer to that commit, updates
docs/ghostty-fork.md, and addstest_notifications.pyto the nightly socket tests.The GhosttyKit prebuilt for the new SHA is published by this PR's Build GhosttyKit run. Its checksum is pinned in a follow-up commit on this branch.