Repository navigation
fix: full audit sweep (2026-10-01) - #395
Merged
Merged
Conversation
…onsent, and socket errors
# Conflicts: # GhosttyTabs.xcodeproj/project.pbxproj
# Conflicts: # GhosttyTabs.xcodeproj/project.pbxproj
# Conflicts: # GhosttyTabs.xcodeproj/project.pbxproj # Resources/Localizable.xcstrings
# Conflicts: # GhosttyTabs.xcodeproj/project.pbxproj # Resources/Localizable.xcstrings
# Conflicts: # GhosttyTabs.xcodeproj/project.pbxproj # tests_v2/ci_subset.txt
… never lands last
…pare worktree realpaths
Member
Author
|
Includes #397's two commits (Codex hooks updated in place on reinstall) at the tip. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes the High and Medium findings from the 2026-10-01 full audit, plus the cheap Lows. The changes people will notice:
git statusand the review diff can no longer run a repo'score.fsmonitorordiff.externalhooks.unit-testsgate no longer fails on PRs that skip the app jobs.not_foundorinvalid_paramsinstead ofunavailable.Things existing users will see once
programa.jsonasks for approval one more time (trust entries now record a per-file digest).install-integrationwithout a terminal needs--yes.--all-domainsgets everything.All of these are in the CHANGELOG.
Review order
close-windowrefusing the refnew-windowprints.Test plan
WindowCloseConfirmCancelUITestspasses inui-regressions(red button and Ctrl-Cmd-W, launch window and second window)BonsplitTestsrun in unit shard 2 is green, or each failure is triagedwindows-buildcompiles the new paste confirmation dialogChecked on a tagged build before opening this:
sleep 1000running: red button 5/5 and Ctrl-Cmd-W 5/5 showed one dialog, and Cancel kept the windowresize-paneat a pane's outer edge and the-xshrink refusal behave as tmux doesAfter merge (owner)
releaseenvironment tomainand move the signing and Sparkle secrets into it.