Repository navigation
chore: mark vendor/bonsplit as our own code for review - #374
Merged
Merged
Conversation
![darkestdarky-bot[bot]](https://avatars.githubusercontent.com/in/3783368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Blocking: 0
The diff adds a .gitattributes entry marking vendor/bonsplit as non-vendored for GitHub linguist and review tooling. No P0 or P1 issues are visible: there are no secrets, trust-boundary inputs, data-loss paths, type-safety escapes, relaxed tests, waterfalls, accessibility changes, manual memoization, new dependencies, or scope creep beyond the stated chore.
Review coverage: 8/8 diff lines supplied. Partial input (truncated: standards). Inline comments are limited to fully visible, valid right-side hunks. Reviewed commit: 0f9af7e872d0bc474bd6ec513ccdfc307b0bb748.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Tells GitHub and darky that
vendor/bonsplit/is our code, not a third-party copy. GitHub stops collapsing bonsplit diffs as vendored. Once darkroom-os#739 deploys, darky reviews bonsplit changes instead of leavingdarky/reviewat "files unseen", which today blocks every PR that touches bonsplit.Test plan
vendor/bonsplit/gets a full darky review