[hakarrr]

What & why

The unsubscribe callback returned by addElement() deletes the SnapElement from the map without calling its destroy() method. Its body and element ResizeObservers remain connected. Calling Snap.destroy() later does not clean them up either, because the removed element is no longer in the map. The same happens through addElements().

Destroy the element before deleting its map entry. The optional lookup makes repeat unsubscribe safe, and the existing deletion return value is preserved. Other registered elements stay active.

Found during lifecycle testing of the snap plugin; there is no separate issue. This is independent of the horizontal alignment fix in #565.

How to verify

bun test packages/snap/tests/unsubscribe.test.js
bun run build
bunx biome check packages/snap/src/snap.ts packages/snap/tests/unsubscribe.test.js

The three regressions cover single unsubscribe followed by destroy, group unsubscribe while another element remains registered, and repeated unsubscribe. All three fail against the base and pass with this change. Build and the focused Biome check pass.

Also checked the built browser bundle in Chromium using real ResizeObservers (subclassed only to record disconnect() calls), a real DOM element, and a minimal Lenis event stub. After remove(); snap.destroy(), both observers remain connected on the base and both are disconnected with the fix. No dependencies added.

Checklist

• PR is focused on a single logical change
• Linked the related issue (or explained why there isn't one)
• Lint/format/tests pass locally (focused commands above)
• Updated docs/types where relevant (no API change)

[vercel]

@hakarrr is attempting to deploy a commit to the Darkroom Team on Vercel.

A member of the Team first needs to authorize it.