Repository navigation
fix(core): accept SVG elements as scrollTo targets - #557
Merged
Merged
Conversation
scrollTo() only treated HTMLElement as an element target, so an SVG element was silently ignored. Accept any Element; getBoundingClientRect() and getComputedStyle() work the same on SVG. Refs #551 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrollTo()only treatedHTMLElementas an element target, so passing an SVG element did nothing (no warning, no scroll). TypeScript also rejected it at the call site. Selectors pointing at SVG already worked.Accept any
Element.getBoundingClientRect()andgetComputedStyle()work the same on SVG, so the existing position math applies unchanged. README updated.1.3.x counterpart of #556 (which fixes the v2 variant, where SVG targets jumped to the top).
Refs #551
🤖 Generated with Claude Code