Repository navigation
feat(stories): one shared format for client user stories, tickets, QA and closing comments (OSS-129) - #293
Merged
Conversation
… and closing comments (OSS-129)
…, link the kickoff (OSS-129)
Merged
4 of 5 tasks
Merged
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Gives every person and agent on a client build the same way to write, work and close tickets. A new
/storiesskill takes a signed scope to a user stories doc, stops until the client approves it, then writes the tickets, kickoff and QA checklist from shared templates./buildtreats a ticket's acceptance criteria as its done list and ends with a closing comment, and/dr-reviewcan review tickets and flag the patterns that made the Sweet Death first pass thin.Fixes OSS-129.
Where each piece sits
We checked each piece against the existing skills before adding anything:
skills/stories/SKILL.mdcontext-docis closest, but it writes a glossary and ADRs for engineers, not client-facing stories.skills/stories/references/skills/build/SKILL.mdskills/dr-review/SKILL.md, new "Ticket Review" variantagents/linear.md, newticketsandreview-readyeventsshare-learningorrules/The skill count goes from 25 to 26.
lint-skills.tsasks for consolidation instead of a raise. We raised it because no existing skill fits (see the table), and the description budget has room (about 5.9 KB of 7.4 KB used). Franco, this is the main thing to decide in review.Summary
Review order:
skills/stories/SKILL.md, then its fourreferences/, then the /build and /dr-review diffs. The rest is registration./stories: seven steps (scope tickets, user stories, implementation review, tickets, kickoff, QA checklist, closing comment). It writes files to the folder the team already uses, or.context/stories/<client>/, and stops after the stories doc for client approval even when told the client will approve. Tickets go to Linear through thelinearagent or to GitHub withgh issue create. The skill text names no tracker fields itself./build: reads a ticket's criteria, out of scope and open questions in the research gate, and ends a ticket build with a closing comment draft. Anything not seen working goes under "Verified by logic, not live", and the ticket is never marked done from that./dr-review: the Ticket Review variant flags a container parent, implementation detail in criteria, bare design node IDs, boilerplate copied across tickets, and done from a reasoned check./storiesruns the/dr-reviewticket review ontickets.mdand fixes every flag before creating tickets; the session running/storieswalks the QA checklist before launch with thetesteragent and holds the launch on unseen items; the ticket template's Source line links the kickoff.ACTIVE_SKILLS, Claude managed-files manifest v41 (full profile only), Codex runtime manifest v29, the skill guide, MANUAL, README and the counts in.claude/AGENTS.md.Test Plan
bun run typecheck,lint(same 31 warnings as main),lint:skills(26 skills, 0 errors),lint:links,lint:agents: clean.bun run test: 3180 pass, 8 fail. The same 8 fail on main on this machine: npm-installer x3, safety-net removed-cwd x3, Codex TOML x1, runtime-dependencies x1.tests/install-e2e.test.tsandtests/codex-install.test.ts: 307 pass, 0 fail.build-closing-commentand the three other build cases passed, anddr-review-generic-landingpassed.dr-review-local-difffailed once. That case reviews a local diff, which this change doesn't touch, but I haven't confirmed whether it's flaky. The run stopped at the cap beforestories-approval-stopanddr-review-ticket-antipatternsran.bun src/scripts/eval-changed.ts --base origin/mainto see them./storieson a real scope, aticketsevent creating Linear issues, or/dr-reviewon the real Sweet Death first pass (the eval uses a synthetic copy of its patterns).