Repository navigation
Conversation
arzafran
deleted the
franco/oss-127-audit-performance-always-checks-fonts-for-subsetting-and
branch
November 4, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fonts get checked at every performance audit instead of only when someone remembers to paste the subsetting prompt at project handoff.
/audit performancenow measures each self-hosted font and what the site actually uses. A font carrying characters, weights or features the site never uses, or one that's preloaded where nothing above the fold needs it, becomes a measured finding, and the subsetting procedure from #273 is the fix.Linear: OSS-127
Summary
skills/audit/SKILL.md, Performance mode:docs/performance-reference.md. The finding's direction is that procedure, so pixel diffs and a person's sign-off on any visible change come with it. A repo with a subset script gets its--checkrun, and a missing CI step for it is a LOW finding.src/lib/lint-skills.ts: the audit skill's line limit drops from 696 to 694, because the change made the file shorter.evals/audit-perf-fonts: a Next app that can't be built, with a preloaded variable font, weights 400 and 650,ss01, accented characters andhyphens: auto. The audit has to plan the font measurements, tie them to what the site uses, and report no font numbers it couldn't measure.Test Plan
bun run typecheckexits 0bun run test: 3144 pass, 0 failbun run lint:skills: 0 errorsauditeval cases pass, including the new one ($1.24)