Add globals - #137
Closed
DavisVaughan wants to merge 1 commit into
Closed
Add globals#137DavisVaughan wants to merge 1 commit into
DavisVaughan wants to merge 1 commit into
Conversation
Contributor
|
@W-Mohammed could you investigate - think it's as simple as changing "location" to another column name in the code. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Feb 19, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, we are working on the next version of dplyr and your package was flagged in our reverse dependency checks.
We have removed the defunct function
dplyr::location().Your package does one of two things:
It re-exports
dplyr::location(), which has been defunct for many years and has now been removed from dplyr.It references a column named
location, likely in amutate()orsummarise(), but does not note this as a global variable withutils::globalVariables("location"). In this case, you got lucky that dplyr exportedlocation(), meaning that you did not need a global variable for"location". Since we have removeddplyr::location(), your package will need this now.dplyr will be released on January 31, 2026. If you could please send an update of your package to CRAN before then, that would help us out a lot! Thanks!