Fix inline vertical-align top and bottom alignment - #1613
Open
YOSEFTT wants to merge 3 commits into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix inline vertical-align top and bottom alignment
Summary
Fixes reversed placeholder alignment for inline
vertical-align: topandvertical-align: bottom.The previous placeholder mapping made
topandbottomrender in the oppositepositions.
subandsuperstill appeared correct because their padded wrapperadds a second alignment adjustment, so the two effects canceled each other out.
Plain
topandbottomdo not use that wrapper, which exposed the reversedmapping.
Changes
vertical-align: toptoPlaceholderAlignment.bottom.vertical-align: bottomtoPlaceholderAlignment.top.subandsuperplaceholder mappings so their paddedalignment behavior stays unchanged.
inline-block elements, and images.
Verification
git diff --checkflutter test test/style_vertical_align_test.dartfrompackages/core00:53 +26: All tests passed!Note: this is a Flutter widget test, so the supported verification command is
flutter test. A directdart testinvocation is not appropriate here; itloads the test on the plain Dart VM and fails because Flutter's
dart:uilibrary is unavailable there.