Add TestServer.TCP by richard-ash · Pull Request #58 · danschultzer/test_server

richard-ash · 2026-05-21T00:23:27Z

No description provided.

danschultzer · 2026-06-04T13:43:21Z

+  @spec connections(TestServer.instance()) :: [map()]
+  def connections(instance) do
+    GenServer.call(instance, :connections)
+  end


I don't think this is used.

danschultzer · 2026-06-04T13:45:45Z

+  @spec report_error(TestServer.instance(), {struct(), TestServer.stacktrace()}) :: :ok
+  def report_error(instance, {exception, stacktrace}) do
+    options = get_options(instance)
+    report_error_with_options(options, {exception, stacktrace})
+  end


This looks weird, shouldn't it be like how it looks in HTTP and SSH? We should probably DRY it up as well after.

danschultzer · 2026-06-04T13:55:50Z

+    report_error_with_options(state.options, {exception, stacktrace})
+
+    message = Exception.format(:error, exception, stacktrace)
+    :gen_tcp.send(connection.socket, message)


I don't think we want to do any direct gen tcp stuf fhere, it should just pass-thru to the TCP layer or server if that. I think the general idea should be that instance just handles handler/match calls, while the actual execution is defined in the handler itself somewhere else. In this case we can wrap the function with gen_tcp send, or have it done after?

danschultzer · 2026-06-04T13:58:23Z

+      state.connections
+      |> Enum.reduce(state, fn connection, state ->
+        connection
+        |> run_send_handler(to, stacktrace)
+        |> send_response(connection, state)
+      end)


This reads odd, why run it on all connections instead of just having this being single connection in the first place? I guess we can support multi connections but if we do that we should make it more explicit.

danschultzer force-pushed the richard/add-ssh branch from dc7e815 to c76044f Compare May 21, 2026 00:59

Base automatically changed from richard/add-ssh to main May 21, 2026 01:01

richard-ash force-pushed the richard/add-tcp branch 5 times, most recently from 75c5759 to 4e3d05e Compare May 25, 2026 04:53

danschultzer reviewed May 25, 2026

View reviewed changes

Comment thread lib/test_server/tcp.ex

danschultzer reviewed May 25, 2026

View reviewed changes

Comment thread lib/test_server/tcp/server.ex Outdated

richard-ash force-pushed the richard/add-tcp branch 3 times, most recently from 1e0893b to 4f7a37d Compare May 27, 2026 21:23

danschultzer reviewed May 30, 2026

View reviewed changes

Comment thread lib/test_server/tcp/instance.ex Outdated

Comment thread lib/test_server/tcp.ex Outdated

Comment thread README.md Outdated

richard-ash force-pushed the richard/add-tcp branch 2 times, most recently from 77b349d to b77449c Compare May 31, 2026 00:12

danschultzer reviewed May 31, 2026

View reviewed changes

Comment thread lib/test_server/tcp/instance.ex Outdated

richard-ash force-pushed the richard/add-tcp branch 3 times, most recently from f5fca44 to b796fa9 Compare June 2, 2026 23:06

danschultzer reviewed Jun 2, 2026

View reviewed changes

Comment thread lib/test_server/tcp/server.ex Outdated

danschultzer reviewed Jun 2, 2026

View reviewed changes

Comment thread lib/test_server/tcp.ex

danschultzer reviewed Jun 2, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

richard-ash force-pushed the richard/add-tcp branch from b796fa9 to ca2fc2c Compare June 3, 2026 16:14